Conversation
2d19d1a to
77d0720
Compare
Naksen
requested changes
Feb 9, 2026
.kerberos/config_server.py
Outdated
| async def modify_principal( | ||
| self, | ||
| principal_name: str, | ||
| new_principal_name: str | None = None, |
Collaborator
There was a problem hiding this comment.
Put запрос с full modify разве нет ? почему изменения опциональны ?
Collaborator
Author
There was a problem hiding this comment.
следовал из ТЗ, а так согласен, тут логичнее patch
rimu-stack
requested changes
Feb 17, 2026
added 11 commits
February 17, 2026 18:56
… related API endpoints to utilize these schemas for better data handling and validation.
…ests, update API endpoints to accept parameters directly for improved clarity and simplicity.
…ary line breaks for improved readability.
…API interactions - Introduced new request models: AddPrincipalRequest, KtaddRequest, and ModifyPrincipalRequest for better structure and validation. - Updated API endpoints to use the new request models, ensuring correct JSON structure for principal creation and keytab addition. - Enhanced error handling and logging for keytab operations. - Refactored existing methods to accommodate new parameters for encryption algorithms and random key generation.
…o improve parameter handling and request structure - Modified the API endpoints for adding and renaming principals to align with new request models. - Adjusted assertions in tests to reflect changes in the expected arguments for kadmin methods. - Enhanced clarity by consolidating parameters in API requests.
…g unnecessary None return
…s to modify principal functionality - Removed the rename_princ method from KAdminLocalManager and replaced it with modify_princ. - Updated API endpoint from rename_principal to modify_principal to reflect the new naming convention. - Adjusted related methods and error codes to use modify_principal terminology for consistency across the codebase.
…PI endpoints - Eliminated the reset_principal_pw method from KerberosService and KerberosFastAPIAdapter. - Removed the corresponding API endpoint for resetting principal passwords from krb5_router. - Updated AuthorizationRules to reflect the removal of the KRB_RESET_PRINCIPAL_PW constant.
- Renamed `new_principal_name` to `new_name` in `ModifyPrincipalRequest` for clarity. - Updated method signatures and API interactions to use the new parameter name across various classes and modules. - Adjusted tests to reflect changes in the principal modification logic and method calls.
- Removed the ALGORITHM_MAP and the _parse_algorithms method to simplify algorithm processing. - Updated add_princ and modify logic to directly use the algorithms parameter, enhancing clarity and reducing complexity. - Adjusted related method calls to ensure consistent handling of algorithm parameters across principal modifications.
- Updated AddPrincipalRequest and KtaddRequest models for improved clarity in parameter handling. - Simplified the add_principal and modify_principal methods to streamline algorithm and password processing. - Changed logging level for missing base directories in update_krb5_config to warning for better visibility. - Adjusted API interactions to ensure consistent naming conventions for principal parameters.
299e57d to
25719bb
Compare
rimu-stack
requested changes
Feb 18, 2026
Naksen
approved these changes
Feb 18, 2026
- Renamed KRBAPIRenamePrincipalError to KRBAPIModifyPrincipalError for consistency with modify principal functionality. - Updated exception handling in KerberosService and ModifyRequest to reflect the new error class name. - Adjusted imports across modules to ensure proper usage of the modified error class.
rimu-stack
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавление функционала в работу с kadmin_api
в ktadd был добавлен атрибут is_rand_key
изменил создание принципала и модификацию. теперь это post и put соответственно по урлу /principal
в kadmind добавленпа обработка algorithms